Don't try to mock UnitOfWork as it's final#2843
Merged
Merged
Conversation
teohhanhui
force-pushed
the
fix/mongodb-odm-uow-final
branch
from
June 5, 2019 17:01
6ca5e5f to
2b7a890
Compare
1 task
teohhanhui
force-pushed
the
fix/mongodb-odm-uow-final
branch
from
June 5, 2019 17:12
2b7a890 to
cdef5ed
Compare
alanpoulain
reviewed
Jun 6, 2019
alanpoulain
reviewed
Jun 6, 2019
teohhanhui
force-pushed
the
fix/mongodb-odm-uow-final
branch
3 times, most recently
from
June 6, 2019 11:13
99c6c43 to
5928b4f
Compare
Contributor
Author
|
Need to fix this: doctrine/DoctrineMongoDBBundle#557 |
teohhanhui
force-pushed
the
fix/mongodb-odm-uow-final
branch
2 times, most recently
from
June 6, 2019 12:48
09c98a2 to
828ba3e
Compare
teohhanhui
commented
Jun 6, 2019
| "behat/symfony2-extension": "^2.1.1", | ||
| "behatch/contexts": "3.1.0", | ||
| "doctrine/annotations": "^1.2", | ||
| "doctrine/data-fixtures": "^1.2.2", |
Contributor
Author
There was a problem hiding this comment.
Temporary workaround for doctrine/DoctrineMongoDBBundle#557
teohhanhui
force-pushed
the
fix/mongodb-odm-uow-final
branch
from
June 6, 2019 13:09
828ba3e to
2e0dced
Compare
dunglas
approved these changes
Jun 7, 2019
Member
|
Thanks @teohhanhui! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also re-add mongodb packages to
require-devas we want developers to be able to runphpstansuccessfully. This means they must haveext-mongodb, but it's easy to satisfy this requirement...